]> git.baikalelectronics.ru Git - kernel.git/commit
ARM: versatile: fix MMC/SD interrupt assignment
authorLinus Walleij <linus.walleij@linaro.org>
Tue, 5 Jan 2016 08:59:30 +0000 (09:59 +0100)
committerOlof Johansson <olof@lixom.net>
Thu, 7 Jan 2016 05:32:19 +0000 (06:32 +0100)
commit5db271a1819f82688dce8ee7a6555b471769eaa2
treea05cd36330adfa5fea22b47d04b83e3cba979798
parent02b86a3e71fd09807a67219f87bb3bf7fb92e5f8
ARM: versatile: fix MMC/SD interrupt assignment

Commit 2906300f1427b2c942d57af551dd53def34f1550
"arm/versatile: Fix versatile irq specifications"
has an off-by-one error on the Versatile AB that has
been regressing the Versatile AB hardware for some time.

However it seems like the interrupt assignments have
never been correct and I have now adjusted them according
to the specification. The masks for the valid interrupts
made it impossible to assign the right SIC interrupt
for the MMCI, so I went in and fixed these to correspond
to the specifications, and added references if anyone
wants to double-check.

Due to the Versatile PB including the Versatile AB
as a base DTS file, we need to override and correct
some values to correspond to the actual changes in the
hardware.

For the Versatile PB I don't think the IRQ line
assignment for MMCI has ever been correct for either of
the two MMCI blocks. It would be nice if someone with the
physical PB board could test this.

Patch tested on the Versatile AB, QEMU for Versatile AB
and QEMU for Versatile PB.

Cc: Rob Herring <robh@kernel.org>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: stable@vger.kernel.org
Fixes: 2906300f1427 ("arm/versatile: Fix versatile irq specifications")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Olof Johansson <olof@lixom.net>
arch/arm/boot/dts/versatile-ab.dts
arch/arm/boot/dts/versatile-pb.dts