]> git.baikalelectronics.ru Git - kernel.git/commit
mpt3sas: Fix warnings exposed by W=1
authorCalvin Owens <calvinowens@fb.com>
Fri, 29 Jul 2016 04:38:22 +0000 (21:38 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 9 Aug 2016 01:15:32 +0000 (21:15 -0400)
commit5d5932ebf6cf38f429b3f7b84ec88fdd6464585f
tree3cc652dab5dc316210ca8ac033beb003b4084e72
parentd8bf4d640d693be0454dd306093144adba7d8bab
mpt3sas: Fix warnings exposed by W=1

Trivial non-functional changes for a couple annoying things:

  1) Functions local to files are not declared static, which is
  frustrating when reading the code because it's non-obvious at first
  glance what's actually called from other files.

  2) Set-but-unused variables abound, presumably to mask -Wunused-result
  errors in the past. None of these are flagged today though (with one
  exception noted below), so remove them.

Fixing (2) exposed the fact that we improperly ignore the return value
of scsi_device_reprobe() in _scsih_reprobe_lun(). Fixing the calling
code to deal with the potential error is non-trivial, so for now just
WARN().

Signed-off-by: Calvin Owens <calvinowens@fb.com>
Acked-by: Chaitra P B <chaitra.basappa@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpt3sas/mpt3sas_base.c
drivers/scsi/mpt3sas/mpt3sas_config.c
drivers/scsi/mpt3sas/mpt3sas_ctl.c
drivers/scsi/mpt3sas/mpt3sas_scsih.c
drivers/scsi/mpt3sas/mpt3sas_transport.c