]> git.baikalelectronics.ru Git - kernel.git/commit
ionic: don't remove netdev->dev_addr when syncing uc list
authorShannon Nelson <snelson@pensando.io>
Fri, 8 Oct 2021 19:38:01 +0000 (12:38 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 9 Oct 2021 10:56:59 +0000 (11:56 +0100)
commit5c976a56570f29aaf4a2f9a1bf99789c252183c9
tree884d329550e2e7e9e7ffb248474bb4b88d8872a7
parentbe0499369d6376e70b5b80bbced94c0c32d508b1
ionic: don't remove netdev->dev_addr when syncing uc list

Bridging, and possibly other upper stack gizmos, adds the
lower device's netdev->dev_addr to its own uc list, and
then requests it be deleted when the upper bridge device is
removed.  This delete request also happens with the bridging
vlan_filtering is enabled and then disabled.

Bonding has a similar behavior with the uc list, but since it
also uses set_mac to manage netdev->dev_addr, it doesn't have
the same the failure case.

Because we store our netdev->dev_addr in our uc list, we need
to ignore the delete request from dev_uc_sync so as to not
lose the address and all hope of communicating.  Note that
ndo_set_mac_address is expressly changing netdev->dev_addr,
so no limitation is set there.

Fixes: 2a654540be10 ("ionic: Add Rx filter and rx_mode ndo support")
Signed-off-by: Shannon Nelson <snelson@pensando.io>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/pensando/ionic/ionic_lif.c