]> git.baikalelectronics.ru Git - kernel.git/commit
perf session: Correct buffer copying when peeking events
authorLeo Yan <leo.yan@linaro.org>
Sat, 5 Jun 2021 05:29:57 +0000 (13:29 +0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 11 Jun 2021 15:54:24 +0000 (12:54 -0300)
commit5c807a6b44c5844af2973027b2f98a9349083666
tree4bfc1b92225ba91c80725214098f380901d7921d
parent4aa24fbdfb733dc921385f7e717996c98af8be8d
perf session: Correct buffer copying when peeking events

When peeking an event, it has a short path and a long path.  The short
path uses the session pointer "one_mmap_addr" to directly fetch the
event; and the long path needs to read out the event header and the
following event data from file and fill into the buffer pointer passed
through the argument "buf".

The issue is in the long path that it copies the event header and event
data into the same destination address which pointer "buf", this means
the event header is overwritten.  We are just lucky to run into the
short path in most cases, so we don't hit the issue in the long path.

This patch adds the offset "hdr_sz" to the pointer "buf" when copying
the event data, so that it can reserve the event header which can be
used properly by its caller.

Fixes: 046b7bd2cb0d ("perf session: Add perf_session__peek_event()")
Signed-off-by: Leo Yan <leo.yan@linaro.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20210605052957.1070720-1-leo.yan@linaro.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/session.c