]> git.baikalelectronics.ru Git - kernel.git/commit
fm10k: prevent multiple threads updating statistics
authorJacob Keller <jacob.e.keller@intel.com>
Tue, 7 Jun 2016 23:08:45 +0000 (16:08 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 20 Jul 2016 22:22:10 +0000 (15:22 -0700)
commit5c739dc3bda8350ced5a82a7aa73728a645a20a6
treea0422d066915f931b98a2955b0e9aa5f4bc83154
parent7337afeeb768dc59b9fc3d8f3121c137ca3bab4b
fm10k: prevent multiple threads updating statistics

Also prevent updating stats while the interface is down. If we're
already updating stats, just return doing nothing. When we take the
device down, block stat updates until we come back up. This ensures that
we avoid tearing down rings when we're updating statistics, and prevents
updating statistics until we're up.

We can't re-use the __FM10K_DOWN for this because it wouldn't prevent
multiple threads from accessing statistics. Neither does it prevent the
case where we start updating stats and then start going down in another
thread.

The fm10k_get_stats64 is except from this, because it has a completely
different flow which does not suffer from the same issues as
fm10k_update_stats might.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Krishneil Singh <Krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/fm10k/fm10k.h
drivers/net/ethernet/intel/fm10k/fm10k_pci.c