drm/sun4i: Use drm_fbdev_generic_setup()
authorNoralf Trønnes <noralf@tronnes.org>
Thu, 25 Oct 2018 20:13:38 +0000 (22:13 +0200)
committerNoralf Trønnes <noralf@tronnes.org>
Thu, 1 Nov 2018 14:25:11 +0000 (15:25 +0100)
commit5bd8a68e3196ba93c3481ba45b4f6d60a2bdbc6d
tree60f8d9e2983db10f31ce025e0b28bde67dd6f0b8
parent56a8360394c681aea99b7d3a188891d4e2abc6cc
drm/sun4i: Use drm_fbdev_generic_setup()

The CMA helper is already using the drm_fb_helper_generic_probe part of
the generic fbdev emulation. This patch makes full use of the generic
fbdev emulation by using its drm_client callbacks. This means that
drm_mode_config_funcs->output_poll_changed and drm_driver->lastclose are
now handled by the emulation code. Additionally fbdev unregister happens
automatically on drm_dev_unregister().

The drm_fbdev_generic_setup() call is put after drm_dev_register() in the
driver. This is done to highlight the fact that fbdev emulation is an
internal client that makes use of the driver, it is not part of the
driver as such. If fbdev setup fails, an error is printed, but the driver
succeeds probing.

Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181025201340.34227-8-noralf@tronnes.org
drivers/gpu/drm/sun4i/sun4i_drv.c
drivers/gpu/drm/sun4i/sun4i_framebuffer.c
drivers/gpu/drm/sun4i/sun4i_framebuffer.h