]> git.baikalelectronics.ru Git - kernel.git/commit
ipv4: fix memory leaks in udp_sendmsg, ping_v4_sendmsg
authorAndrey Ignatov <rdna@fb.com>
Thu, 10 May 2018 17:59:34 +0000 (10:59 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 11 May 2018 16:00:58 +0000 (12:00 -0400)
commit5b90c803c9a69894f486a3b4ff6ecfa4e3be8163
treef68daaa874de1b25206aaf0a81c04c455b5a8563
parent3f184e43bde2118f3ebcf7859dd0aa328433629e
ipv4: fix memory leaks in udp_sendmsg, ping_v4_sendmsg

Fix more memory leaks in ip_cmsg_send() callers. Part of them were fixed
earlier in 49587447b55d.

* udp_sendmsg one was there since the beginning when linux sources were
  first added to git;
* ping_v4_sendmsg one was copy/pasted in cfce3383c7be.

Whenever return happens in udp_sendmsg() or ping_v4_sendmsg() IP options
have to be freed if they were allocated previously.

Add label so that future callers (if any) can use it instead of kfree()
before return that is easy to forget.

Fixes: cfce3383c7be (net: ipv4: add IPPROTO_ICMP socket kind)
Signed-off-by: Andrey Ignatov <rdna@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ping.c
net/ipv4/udp.c