]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "drm/i915: enable HiZ Raw Stall Optimization on IVB"
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 4 Mar 2014 09:41:43 +0000 (09:41 +0000)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 5 Mar 2014 20:30:04 +0000 (21:30 +0100)
commit5b6c866acc5f979565ddf49264d5aa4aebd1a660
tree63763b085bc0739f992318e3b1570e2ca6d6f702
parent353c2bace1bf386d86a7e135bc0317a7198b13b4
Revert "drm/i915: enable HiZ Raw Stall Optimization on IVB"

This reverts commit cb012063ba223d8ae3ed0c5f156a1863819fc230.

This optimization causes widespread corruption in games, and even in
glxgears, on my ivb:gt1. The corruption appears like z-fighting of
overlapping polygons in the HiZ buffer.

The observation ties in very closely with the description of the
optimization disabled by default on IVB:

"The Hierarchical Z RAW Stall Optimization allows non-overlapping
polygons in the same 8x4 pixel/sample area to be processed without
stalling waiting for the earlier ones to write to Hierarchical Z
buffer."

No reason is given for why it is disabled by default, usually for such
optimizations it is that it is incomplete. However, there is no
indication whether this a gt1 only issue either. Before considering
reenabling this optimization, I would first suggest reproducing the
corruption in piglit.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=75623
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Chia-I Wu <olv@lunarg.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_pm.c