]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: dsi: fix pipe-off timeout due to port vs. pipe disable ordering
authorImre Deak <imre.deak@intel.com>
Tue, 27 May 2014 16:00:09 +0000 (19:00 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 5 Jun 2014 06:52:33 +0000 (08:52 +0200)
commit5ab7b5c5884c7bf34d011751720b8fec67551921
treeccadd41e15774914d38dc9dc5b44bd9437414544
parenteb08f6fc15511aa4dff115393a448a3b4b55ec99
drm/i915: dsi: fix pipe-off timeout due to port vs. pipe disable ordering

If we disable first the port (by disabling DPI) and only then the
display pipe the pipe-off flag will never be set, possibly leading to a
hanged pipe state at the next modeset-enable.

Note that according to the VLV2 display cluster HAS, we should disable
the port before the pipe. This doesn't seem to match reality based on
the above and it's also asymmetric with the enabling sequence, where we
first enable the port and then the pipe.

v2:
- send the panel shutdown command before stopping the pipe, since this
  is the recommended sequence (Shobhit)

Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Shobhit Kumar <shobhit.kumar@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_dsi.c