]> git.baikalelectronics.ru Git - kernel.git/commit
firewire: core: clean up config ROM related defined constants
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Wed, 14 Apr 2010 20:30:18 +0000 (22:30 +0200)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Mon, 19 Apr 2010 18:00:44 +0000 (20:00 +0200)
commit5a96ae1eb8341674d36c82a044d111cbed8fe243
tree1b649a30c0c3263b1cbef23d0fcdc049228c5e8d
parentc86feeb330b8d77a81a100cc7a9a85cf95236ba9
firewire: core: clean up config ROM related defined constants

Clemens Ladisch pointed out that
  - BIB_IMC is not named like the field is called in the standard,
  - readers of the code may get worried about the magic 0x0c0083c0,
  - a CSR_NODE_CAPABILITIES key is there in the header but not put to
    good use.

So let's rename BIB_IMC, add a defined constant for Node_Capabilities
and a comment which reassures people that somebody thought about it and
they don't have to (or if they still do, tell them where they have to
look for confirmation), and prune our incomplete and arbitrary set of
defined constants of CSR key IDs.  And there is a nother magic number,
that of Bus_Information_Block.Bus_Name, to be defined and commented.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
drivers/firewire/core-card.c
include/linux/firewire.h