]> git.baikalelectronics.ru Git - kernel.git/commit
gpio/rockchip: extended debounce support is only available on v2
authorHeiko Stuebner <heiko@sntech.de>
Mon, 13 Sep 2021 22:49:23 +0000 (00:49 +0200)
committerBartosz Golaszewski <brgl@bgdev.pl>
Wed, 22 Sep 2021 09:31:43 +0000 (11:31 +0200)
commit5a9589440599f685cd27c48652c692d92d8c1834
treed0e1a301015e855cd120b1bdcdbba71851440274
parent8d6ca8b936429e1a66be7a733e358d2256f22055
gpio/rockchip: extended debounce support is only available on v2

The gpio driver runs into issues on v1 gpio blocks, as the db_clk
and the whole extended debounce support is only ever defined on v2.
So checking for the IS_ERR on the db_clk is not enough, as it will
be NULL on v1.

Fix this by adding the needed condition for v2 first before checking
the existence of the db_clk.

This caused my rk3288-veyron-pinky to enter a reboot loop when it
tried to enable the power-key as adc-key device.

Fixes: c8e994fbf2a8 ("gpio/rockchip: support next version gpio controller")
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
drivers/gpio/gpio-rockchip.c