]> git.baikalelectronics.ru Git - kernel.git/commit
spi: spi-geni-qcom: Remove confusing comment about setting the watermark
authorDouglas Anderson <dianders@chromium.org>
Mon, 12 Jul 2021 15:50:17 +0000 (08:50 -0700)
committerMark Brown <broonie@kernel.org>
Wed, 14 Jul 2021 15:37:58 +0000 (16:37 +0100)
commit5a607e6648a997616aee7378f178bdaf1efb7277
tree21fcc860a3753877eeaabbe2060b302a819c430b
parente00b9a54774063cebce76da1637398474364d3ed
spi: spi-geni-qcom: Remove confusing comment about setting the watermark

The comment in setup_fifo_xfer() about setting the watermark wasn't
quite proper grammar and also stopped making sense around commit
329fa7a15b47 ("spi: spi-geni-qcom: Don't wait to start 1st transfer if
transmitting"). After that commit we actually start the transfer
_before_ the watermark interrupt comes.

I don't think the comment really has any value anymore. We've already
got a comment when we grab the spinlock saying that our interrupt can
come any time as a result of the things in the locked section. Let's
just remove it.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Vinod Koul <vkoul@kernel.org>
Link: https://lore.kernel.org/r/20210712085010.1.Ie3bb9f9d30d6475bb75251d32635194c1c72b9ee@changeid
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-geni-qcom.c