]> git.baikalelectronics.ru Git - kernel.git/commit
ice: don't allow to run ice_send_event_to_aux() in atomic ctx
authorAlexander Lobakin <alexandr.lobakin@intel.com>
Wed, 23 Mar 2022 12:43:53 +0000 (13:43 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 23 Mar 2022 17:40:41 +0000 (10:40 -0700)
commit5a3156932da06f09953764de113419f254086faf
tree3bad49a37029667e33bfee2f30e9642d379576d1
parent32d53c0aa3a7b727243473949bad2a830b908edc
ice: don't allow to run ice_send_event_to_aux() in atomic ctx

ice_send_event_to_aux() eventually descends to mutex_lock()
(-> might_sched()), so it must not be called under non-task
context. However, at least two fixes have happened already for the
bug splats occurred due to this function being called from atomic
context.
To make the emergency landings softer, bail out early when executed
in non-task context emitting a warn splat only once. This way we
trade some events being potentially lost for system stability and
avoid any related hangs and crashes.

Fixes: 348048e724a0e ("ice: Implement iidc operations")
Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
Tested-by: Michal Kubiak <michal.kubiak@intel.com>
Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Acked-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/intel/ice/ice_idc.c