]> git.baikalelectronics.ru Git - kernel.git/commit
netfilter: synproxy: Fix out of bounds when parsing TCP options
authorMaxim Mikityanskiy <maximmi@nvidia.com>
Thu, 10 Jun 2021 16:40:29 +0000 (19:40 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 10 Jun 2021 21:26:18 +0000 (14:26 -0700)
commit59eeadd3c0452328aba3fa22434e2492b83793b5
tree37b7b80b5a8f0c2156bb51e9af0fd0be5fba0ea0
parenta2c76791611d650d20cec3397436800e01baaaa6
netfilter: synproxy: Fix out of bounds when parsing TCP options

The TCP option parser in synproxy (synproxy_parse_options) could read
one byte out of bounds. When the length is 1, the execution flow gets
into the loop, reads one byte of the opcode, and if the opcode is
neither TCPOPT_EOL nor TCPOPT_NOP, it reads one more byte, which exceeds
the length of 1.

This fix is inspired by commit fae93b8ae922 ("ipv4: tcp_input: fix stack
out of bounds when parsing TCP options.").

v2 changes:

Added an early return when length < 0 to avoid calling
skb_header_pointer with negative length.

Cc: Young Xiao <92siuyang@gmail.com>
Fixes: da05c55e4400 ("netfilter: add SYNPROXY core/target")
Signed-off-by: Maxim Mikityanskiy <maximmi@nvidia.com>
Reviewed-by: Florian Westphal <fw@strlen.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netfilter/nf_synproxy_core.c