]> git.baikalelectronics.ru Git - kernel.git/commit
tap: call skb_probe_transport_header after setting skb->dev
authorWillem de Bruijn <willemb@google.com>
Sun, 30 Dec 2018 22:21:05 +0000 (17:21 -0500)
committerDavid S. Miller <davem@davemloft.net>
Tue, 1 Jan 2019 20:01:02 +0000 (12:01 -0800)
commit5998c7fed2dd2004d2b104a16183e3fc4fb97732
tree6a0dd106ba28258fa65fb18602aa6b253fd69f70
parentd672337d6235025f6ac9ecac729620a104893381
tap: call skb_probe_transport_header after setting skb->dev

The BPF flow dissector expects either skb->sk or skb->dev set on
all skbs. Delay flow dissection until after skb->dev is set.

This requires calling from within an rcu read-side critical section.
That is fine, see also the call from tun_xdp_one.

Fixes: f83d422c274f ("flow_dissector: lookup netns by skb->sk if skb->dev is NULL")
Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/tap.c