]> git.baikalelectronics.ru Git - kernel.git/commit
soc/fsl/qe: fix err handling of ucc_of_parse_tdm
authorWen Yang <wen.yang99@zte.com.cn>
Wed, 2 Jan 2019 17:09:53 +0000 (01:09 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 4 Jan 2019 20:50:43 +0000 (12:50 -0800)
commit592fe8ad535bd304afe00400d96a40135a274dc9
tree136f714932c2a9ff615fcf16745a4072b402402a
parentfed16a428db5aab7e437791832c7d5297a571af5
soc/fsl/qe: fix err handling of ucc_of_parse_tdm

Currently there are some issues with the ucc_of_parse_tdm function:
1, a possible null pointer dereference in ucc_of_parse_tdm,
detected by the semantic patch deref_null.cocci,
with the following warning:
drivers/soc/fsl/qe/qe_tdm.c:177:21-24: ERROR: pdev is NULL but dereferenced.
2, dev gets modified, so in any case that devm_iounmap() will fail
even when the new pdev is valid, because the iomap was done with a
 different pdev.
3, there is no driver bind with the "fsl,t1040-qe-si" or
"fsl,t1040-qe-siram" device. So allocating resources using devm_*()
with these devices won't provide a cleanup path for these resources
when the caller fails.

This patch fixes them.

Suggested-by: Li Yang <leoyang.li@nxp.com>
Suggested-by: Christophe LEROY <christophe.leroy@c-s.fr>
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Reviewed-by: Peng Hao <peng.hao2@zte.com.cn>
CC: Julia Lawall <julia.lawall@lip6.fr>
CC: Zhao Qiang <qiang.zhao@nxp.com>
CC: David S. Miller <davem@davemloft.net>
CC: netdev@vger.kernel.org
CC: linuxppc-dev@lists.ozlabs.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/fsl_ucc_hdlc.c
drivers/soc/fsl/qe/qe_tdm.c