]> git.baikalelectronics.ru Git - kernel.git/commit
tools/power turbostat: Fix offset overflow issue in index converting
authorCalvin Walton <calvin.walton@kepstin.ca>
Wed, 28 Apr 2021 09:09:16 +0000 (17:09 +0800)
committerLen Brown <len.brown@intel.com>
Tue, 4 May 2021 22:33:41 +0000 (18:33 -0400)
commit5826a41b7b65b275f5643b97591a914d06b0fa8c
tree8405a2d05e136f55d667267ecb047f9e29ef96bc
parentdfaf204811886b3d2f2b59fb697ea94e90709895
tools/power turbostat: Fix offset overflow issue in index converting

The idx_to_offset() function returns type int (32-bit signed), but
MSR_PKG_ENERGY_STAT is u32 and would be interpreted as a negative number.
The end result is that it hits the if (offset < 0) check in update_msr_sum()
which prevents the timer callback from updating the stat in the background when
long durations are used. The similar issue exists in offset_to_idx() and
update_msr_sum(). Fix this issue by converting the 'int' to 'off_t' accordingly.

Fixes: 9ad138bd928f ("tools/power turbostat: Enable accumulate RAPL display")
Signed-off-by: Calvin Walton <calvin.walton@kepstin.ca>
Signed-off-by: Len Brown <len.brown@intel.com>
tools/power/x86/turbostat/turbostat.c