]> git.baikalelectronics.ru Git - kernel.git/commit
net: bcmgenet: fix OF child-node lookup
authorJohan Hovold <johan@kernel.org>
Mon, 27 Aug 2018 08:21:50 +0000 (10:21 +0200)
committerRob Herring <robh@kernel.org>
Tue, 23 Oct 2018 18:28:52 +0000 (13:28 -0500)
commit57c019a8b77bad18b146907bf06f6318d0fe9ac1
treea9e533986fef1ebdbc12141f91f180508308a9aa
parent3efcef8161564b9ff68e1d5241cbe5bf37ae7b4c
net: bcmgenet: fix OF child-node lookup

Use the new of_get_compatible_child() helper to lookup the mdio child
node instead of using of_find_compatible_node(), which searches the
entire tree from a given start node and thus can return an unrelated
(i.e. non-child) node.

This also addresses a potential use-after-free (e.g. after probe
deferral) as the tree-wide helper drops a reference to its first
argument (i.e. the node of the device being probed).

Fixes: 02583f325ba4 ("net: bcmgenet: add MDIO routines")
Cc: stable <stable@vger.kernel.org> # 3.15
Cc: David S. Miller <davem@davemloft.net>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
drivers/net/ethernet/broadcom/genet/bcmmii.c