]> git.baikalelectronics.ru Git - kernel.git/commit
bio-integrity: Drop bio_integrity_verify BUG_ON in post bip->bip_iter world
authorNicholas Bellinger <nab@linux-iscsi.org>
Thu, 20 Feb 2014 00:52:01 +0000 (00:52 +0000)
committerJens Axboe <axboe@fb.com>
Fri, 21 Feb 2014 23:56:36 +0000 (15:56 -0800)
commit579065951bd5a6b0a9e11d46b0a5c71ce20ae3b3
tree4ec843f5e4eb7ccd641870ac92bc6bac867e7b70
parentf522a5cff7ae1ae2524961e2e3ffdd2a6f910241
bio-integrity: Drop bio_integrity_verify BUG_ON in post bip->bip_iter world

Given that bip->bip_iter.bi_size is decremented after bio_advance() ->
bio_integrity_advance() is called, the BUG_ON() in bio_integrity_verify()
ends up tripping in v3.14-rc1 code with the advent of immutable biovecs
in:

commit 080fcf22b59b36f407144a87983008a79da12613
Author: Kent Overstreet <kmo@daterainc.com>
Date:   Sat Nov 23 17:20:16 2013 -0800

    bio-integrity: Convert to bvec_iter

Given that there is no easy way to ascertain the original bi_size
value, go ahead and drop this BUG_ON().

Reported-by: Sagi Grimberg <sagig@dev.mellanox.co.il>
Reported-by: Akinobu Mita <akinobu.mita@gmail.com>
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Cc: Kent Overstreet <kmo@daterainc.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Jens Axboe <axboe@fb.com>
fs/bio-integrity.c