]> git.baikalelectronics.ru Git - kernel.git/commit
direct-io: Fix sleep in atomic due to sync AIO
authorJan Kara <jack@suse.cz>
Mon, 26 Feb 2018 11:51:43 +0000 (12:51 +0100)
committerJens Axboe <axboe@kernel.dk>
Mon, 26 Feb 2018 16:05:35 +0000 (09:05 -0700)
commit56fe4a3d6e803143814fc27866dac94252104d7e
treeae004ec25c97c1db1ff9804f4bb6b147ca85f786
parent23c71022e0c22abcde801b1a0352261763fb0905
direct-io: Fix sleep in atomic due to sync AIO

Commit ecbcbc0678f0 "fs: add RWF_DSYNC aand RWF_SYNC" added additional
way for direct IO to become synchronous and thus trigger fsync from the
IO completion handler. Then commit 884d5a96cd3a "fs: Use RWF_* flags for
AIO operations" allowed these flags to be set for AIO as well. However
that commit forgot to update the condition checking whether the IO
completion handling should be defered to a workqueue and thus AIO DIO
with RWF_[D]SYNC set will call fsync() from IRQ context resulting in
sleep in atomic.

Fix the problem by checking directly iocb flags (the same way as it is
done in dio_complete()) instead of checking all conditions that could
lead to IO being synchronous.

CC: Christoph Hellwig <hch@lst.de>
CC: Goldwyn Rodrigues <rgoldwyn@suse.com>
CC: stable@vger.kernel.org
Reported-by: Mark Rutland <mark.rutland@arm.com>
Tested-by: Mark Rutland <mark.rutland@arm.com>
Fixes: 884d5a96cd3ad33c5e667a838cbd7d5dc5bb5833
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/direct-io.c