]> git.baikalelectronics.ru Git - kernel.git/commit
USB: gadget: Drop NULL test on list_entry result
authorJulia Lawall <julia@diku.dk>
Sun, 12 Jul 2009 07:43:52 +0000 (09:43 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 23 Sep 2009 13:46:28 +0000 (06:46 -0700)
commit56f0f563190294973ef1fde03b48a2b9c3b0389f
tree1b29534beb35d5aab02c448a1aa0dd406229ca3d
parent49419d279455a3d22dc3a12861d87e21585a4ea6
USB: gadget: Drop NULL test on list_entry result

list_entry, which is an alias for container_of, cannot return NULL, as
there is no way to add a NULL value to a doubly linked list.

A simplified version of the semantic match that findds this problem is as
follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r@
expression x,E;
statement S1,S2;
position p,p1;
@@

*x = list_entry@p(...)
... when != x = E
*if@p1 (x == NULL) S1 else S2
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/gadget/amd5536udc.c