]> git.baikalelectronics.ru Git - kernel.git/commit
s390/qeth: fix false reporting of VNIC CHAR config failure
authorAlexandra Winter <wintera@linux.ibm.com>
Mon, 23 Dec 2019 14:03:23 +0000 (15:03 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 25 Dec 2019 06:41:06 +0000 (22:41 -0800)
commit56da66f104ddf0d189181119be0f0e4a771e2de0
tree1ebdd1dbe4fe35f5ec1bfbd66b0f93b9f30061c9
parenta763c732429e51be069a60a2852bb7dc6d804413
s390/qeth: fix false reporting of VNIC CHAR config failure

Symptom: Error message "Configuring the VNIC characteristics failed"
in dmesg whenever an OSA interface on z15 is set online.

The VNIC characteristics get re-programmed when setting a L2 device
online. This follows the selected 'wanted' characteristics - with the
exception that the INVISIBLE characteristic unconditionally gets
switched off.

For devices that don't support INVISIBLE (ie. OSA), the resulting
IO failure raises a noisy error message
("Configuring the VNIC characteristics failed").
For IQD, INVISIBLE is off by default anyways.

So don't unnecessarily special-case the INVISIBLE characteristic, and
thereby suppress the misleading error message on OSA devices.

Fixes: 7cb7f614c986 ("s390/qeth: add VNICC enable/disable support")
Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
Reviewed-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_l2_main.c