]> git.baikalelectronics.ru Git - kernel.git/commit
mlx4: fix error path in drivers/net/mlx4/en_rx.c
authorIngo Molnar <mingo@elte.hu>
Wed, 26 Nov 2008 00:53:32 +0000 (16:53 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 26 Nov 2008 00:53:32 +0000 (16:53 -0800)
commit56afc5c9758d810442bb376f4f209889f9ee238e
tree230f7d66aab199ca3e0feded8afe4b5e82b94ebd
parent41cb823980b4cbec4ac824c847c547b7cc4be3a2
mlx4: fix error path in drivers/net/mlx4/en_rx.c

this warning:

  drivers/net/mlx4/en_rx.c: In function ‘mlx4_en_activate_rx_rings’:
  drivers/net/mlx4/en_rx.c:412: warning: ‘err’ may be used uninitialized in this function

Triggers because 'err' is uninitialized in the following input
conditions: priv->rx_ring_num is zero and mlx4_en_fill_rx_buffers()
fails.

But even if ->rx_ring_num is nonzero, 'err' will be zero if
mlx4_en_fill_rx_buffers() fails and mlx4_en_activate_rx_rings() returns
success - incorrectly.

So it's best to keep the error code uptodate on mlx4_en_fill_rx_buffers()
calls as well.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/mlx4/en_rx.c