]> git.baikalelectronics.ru Git - kernel.git/commit
Fix/Rewrite of the mipsnet driver]
authorRalf Baechle <ralf@linux-mips.org>
Fri, 11 Jan 2008 17:28:00 +0000 (17:28 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 3 Feb 2008 12:28:10 +0000 (04:28 -0800)
commit567050b89f9327904e9e1995a37a8197a7048a11
tree429dadd456a693c42193c089b6d42d1dbdf1725a
parentfea94e397c724d8745fef92403207e794312f79c
Fix/Rewrite of the mipsnet driver]

This is Thiemo's patch.

----- Forwarded message from Thiemo Seufer <ths@networkno.de> -----

From: Thiemo Seufer <ths@networkno.de>
Date: Sat, 17 Nov 2007 22:29:13 +0000
To: netdev@vger.kernel.org
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: [PATCH, REPOST] Fix/Rewrite of the mipsnet driver
Content-Type: text/plain; charset=us-ascii

Hello All,

currently the mipsnet driver fails after transmitting a number of
packages because SKBs are allocated but never freed. I fixed that
and coudn't refrain from removing the most egregious warts.

- mipsnet.h folded into mipsnet.c, as it doesn't provide any
  useful external interface.
- Free SKB after transmission.
- Call free_irq in mipsnet_close, to balance the request_irq in
  mipsnet_open.
- Removed duplicate read of rxDataCount.
- Some identifiers are now less verbose.
- Removed dead and/or unnecessarily complex code.
- Code formatting fixes.

Tested on Qemu's mipssim emulation, with this patch it can boot a
Debian NFSroot.

Thiemo

Signed-off-by: Thiemo Seufer <ths@networkno.de>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/mipsnet.c
drivers/net/mipsnet.h [deleted file]