]> git.baikalelectronics.ru Git - kernel.git/commit
selftests: mptcp: add missing join check
authorMatthieu Baerts <matthieu.baerts@tessares.net>
Thu, 10 Feb 2022 01:25:07 +0000 (17:25 -0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 10 Feb 2022 05:44:35 +0000 (21:44 -0800)
commit5453269dcbdeeb2c59d9aa74396d7a94f3b89a5b
treec8cefbce1dda74e70bdb183c6714800f1b58f8af
parent12e63481eebc523d0f6bc90ef5f4e1b9ef51d020
selftests: mptcp: add missing join check

This function also writes the name of the test with its ID, making clear
a new test has been executed.

Without that, the ADD_ADDR results from this test was appended at the
end of the previous test causing confusions. Especially when the second
test was failing, we had:

  17 signal invalid addresses     syn[ ok ] - synack[ ok ] - ack[ ok ]
                                  add[ ok ] - echo  [ ok ]
                                  add[fail] got 2 ADD_ADDR[s] expected 3

In fact, this 17th test was OK but not the 18th one.

Now we have:

  17 signal invalid addresses     syn[ ok ] - synack[ ok ] - ack[ ok ]
                                  add[ ok ] - echo  [ ok ]
  18 signal addresses race test   syn[fail] got 2 JOIN[s] syn expected 3
   - synack[fail] got 2 JOIN[s] synack expected
   - ack[fail] got 2 JOIN[s] ack expected 3
                                  add[fail] got 2 ADD_ADDR[s] expected 3

Fixes: 32671cc3faae ("selftests: mptcp: add_addr and echo race test")
Reported-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/mptcp/mptcp_join.sh