]> git.baikalelectronics.ru Git - kernel.git/commit
block: blk-merge: fast-clone bio when splitting rw bios
authorMing Lei <ming.lei@canonical.com>
Thu, 17 Sep 2015 15:58:38 +0000 (09:58 -0600)
committerJens Axboe <axboe@fb.com>
Thu, 17 Sep 2015 15:58:38 +0000 (09:58 -0600)
commit533abda062b605f8a049ac8bcc1280fa3a81a5ca
treeae5daeeaa270e5fb28b4c0a92f82a3dfe8f6e4fc
parent6a013ebe47e3dee48d829861ff2a33e28e389b82
block: blk-merge: fast-clone bio when splitting rw bios

biovecs has become immutable since v3.13, so it isn't necessary
to allocate biovecs for the new cloned bios, then we can save
one extra biovecs allocation/copy, and the allocation is often
not fixed-length and a bit more expensive.

For example, if the 'max_sectors_kb' of null blk's queue is set
as 16(32 sectors) via sysfs just for making more splits, this patch
can increase throught about ~70% in the sequential read test over
null_blk(direct io, bs: 1M).

Cc: Christoph Hellwig <hch@infradead.org>
Cc: Kent Overstreet <kent.overstreet@gmail.com>
Cc: Ming Lin <ming.l@ssi.samsung.com>
Cc: Dongsu Park <dpark@posteo.net>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
This fixes a performance regression introduced by commit fbe004c303,
and allows us to take full advantage of the fact that we have immutable
bio_vecs. Hand applied, as it rejected violently with commit
24da4cf775ea.

Signed-off-by: Jens Axboe <axboe@fb.com>
block/blk-merge.c