]> git.baikalelectronics.ru Git - kernel.git/commit
ext4: fix EXT4_MAX_LOGICAL_BLOCK macro
authorRitesh Harjani <riteshh@linux.ibm.com>
Tue, 5 May 2020 15:43:14 +0000 (17:43 +0200)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 19 May 2020 19:03:37 +0000 (15:03 -0400)
commit530fe540967e0e87105f114f4b86703a2ac1ad48
tree2640df9bf7bd8f4fa637cc91d8b70fb45c94a400
parent8ecc5738678b2f445f0371be7f844ee9bb84f61d
ext4: fix EXT4_MAX_LOGICAL_BLOCK macro

ext4 supports max number of logical blocks in a file to be 0xffffffff.
(This is since ext4_extent's ee_block is __le32).
This means that EXT4_MAX_LOGICAL_BLOCK should be 0xfffffffe (starting
from 0 logical offset). This patch fixes this.

The issue was seen when ext4 moved to iomap_fiemap API and when
overlayfs was mounted on top of ext4. Since overlayfs was missing
filemap_check_ranges(), so it could pass a arbitrary huge length which
lead to overflow of map.m_len logic.

This patch fixes that.

Fixes: ae576a2fc8a8 ("ext4: move ext4_fiemap to use iomap framework")
Reported-by: syzbot+77fa5bdb65cc39711820@syzkaller.appspotmail.com
Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20200505154324.3226743-2-hch@lst.de
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/ext4.h