]> git.baikalelectronics.ru Git - kernel.git/commit
nfp: flower: use struct_size() helper
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 5 Jun 2019 20:38:27 +0000 (15:38 -0500)
committerDavid S. Miller <davem@davemloft.net>
Wed, 5 Jun 2019 23:54:43 +0000 (16:54 -0700)
commit52ce9ee7121fcecbc8c01013f25e0bfda427b04e
tree615acb75601a1451a7b18542c06e314595c5100e
parent2124634930069bafd12abd83dc131a50ae11ab84
nfp: flower: use struct_size() helper

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct nfp_tun_active_tuns {
...
        struct route_ip_info {
                __be32 ipv4;
                __be32 egress_port;
                __be32 extra[2];
        } tun_info[];
};

Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes.

So, replace the following form:

sizeof(struct nfp_tun_active_tuns) + sizeof(struct route_ip_info) * count

with:

struct_size(payload, tun_info, count)

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c