]> git.baikalelectronics.ru Git - kernel.git/commit
[SCSI] libiscsi: fix missed iscsi_task_put in xmit error path
authorMike Christie <michaelc@cs.wisc.edu>
Mon, 16 Oct 2006 22:09:40 +0000 (18:09 -0400)
committerJames Bottomley <jejb@mulgrave.il.steeleye.com>
Wed, 25 Oct 2006 22:13:57 +0000 (15:13 -0700)
commit523bd5439aaf057ff12dcc3846fdd7dc426a7f3b
treeb52d86911134d1d35f44d12171950c9aab07c887
parentebb4e0a1c9863cc6d8ac9d23d0c70710ca204a15
[SCSI] libiscsi: fix missed iscsi_task_put in xmit error path

from bhalevy@gmail.com:

It looks like change 652 to libiscsi.c added some dead code around line
670
                if (rc) {
                        spin_unlock_bh(&conn->session->lock);
                        goto again;
                }

since 5 lines above we goto again if (rc).

It looks like the previous if (rc) should go away if we want to put the
ctask before
breaking out of the while loop with "goto again" (see following patch).

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
drivers/scsi/libiscsi.c