]> git.baikalelectronics.ru Git - kernel.git/commit
phonet: properly unshare skbs in phonet_rcv()
authorEric Dumazet <edumazet@google.com>
Tue, 12 Jan 2016 16:58:00 +0000 (08:58 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 12 Jan 2016 17:05:38 +0000 (12:05 -0500)
commit522a5f9c7d1e600e70d9bc9555aebe7386e3e29a
tree1e77e3616c4ac78cba6eb94d6776423f248ce4ce
parentd877e3a825972cf8f44744db686245a2b15bde87
phonet: properly unshare skbs in phonet_rcv()

Ivaylo Dimitrov reported a regression caused by commit 1fbff6b51856
("dev: add per net_device packet type chains").

skb->dev becomes NULL and we crash in __netif_receive_skb_core().

Before above commit, different kind of bugs or corruptions could happen
without major crash.

But the root cause is that phonet_rcv() can queue skb without checking
if skb is shared or not.

Many thanks to Ivaylo Dimitrov for his help, diagnosis and tests.

Reported-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Tested-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Remi Denis-Courmont <courmisch@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/phonet/af_phonet.c