]> git.baikalelectronics.ru Git - kernel.git/commit
bpf: Replace fput with sockfd_put in sock map
authorZheng Yongjun <zhengyongjun3@huawei.com>
Tue, 29 Dec 2020 13:48:34 +0000 (21:48 +0800)
committerAlexei Starovoitov <ast@kernel.org>
Fri, 8 Jan 2021 21:39:24 +0000 (13:39 -0800)
commit51824ad13c9d07461578a22a6a4f8b4616da949e
tree93eece960e473dc112aa44952fc783cb6363ef9e
parent7f679b13592ac6cc7cef363ce9d6b861fc7f4544
bpf: Replace fput with sockfd_put in sock map

The function sockfd_lookup uses fget on the value that is stored in
the file field of the returned structure, so fput should ultimately
be applied to this value. This can be done directly, but it seems
better to use the specific macro sockfd_put, which does the same
thing.

The cleanup was done using the following semantic patch:
    (http://www.emn.fr/x-info/coccinelle/)

    // <smpl>
    @@
    expression s;
    @@

       s = sockfd_lookup(...)
       ...
    +  sockfd_put(s);
    ?- fput(s->file);
    // </smpl>

Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20201229134834.22962-1-zhengyongjun3@huawei.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
net/core/sock_map.c