]> git.baikalelectronics.ru Git - kernel.git/commit
hwrng: omap3-rom - Call clk_disable_unprepare() on exit only if not idled
authorTony Lindgren <tony@atomide.com>
Sat, 14 Sep 2019 21:02:56 +0000 (14:02 -0700)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 4 Oct 2019 15:06:11 +0000 (01:06 +1000)
commit510178c22553127d1e8cfb0624058589f1703bd8
treec252bd37be51c0cb005c78e28067ca7f2ea8f310
parent470ef3d426ace130434c33f11eb58a0b8b96536a
hwrng: omap3-rom - Call clk_disable_unprepare() on exit only if not idled

When unloading omap3-rom-rng, we'll get the following:

WARNING: CPU: 0 PID: 100 at drivers/clk/clk.c:948 clk_core_disable

This is because the clock may be already disabled by omap3_rom_rng_idle().
Let's fix the issue by checking for rng_idle on exit.

Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Adam Ford <aford173@gmail.com>
Cc: Pali Rohár <pali.rohar@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Tero Kristo <t-kristo@ti.com>
Fixes: d069ab492c66 ("hwrng: OMAP3 ROM Random Number Generator support")
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/omap3-rom-rng.c