]> git.baikalelectronics.ru Git - kernel.git/commit
tuntap: fix a possible race between queue selection and changing queues
authorJason Wang <jasowang@redhat.com>
Wed, 5 Jun 2013 08:44:57 +0000 (16:44 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 10 Jun 2013 21:32:47 +0000 (14:32 -0700)
commit50f52df1195aa8d4dedfb7740da241de50258d03
tree3b310ab023ab438175bd2aa0ccf71814e3760ae9
parentca33742522a8b8e9ce862ddb49e6042accf07711
tuntap: fix a possible race between queue selection and changing queues

Complier may generate codes that re-read the tun->numqueues during
tun_select_queue(). This may be a race if vlan->numqueues were changed in the
same time and can lead unexpected result (e.g. very huge value).

We need prevent the compiler from generating such codes by adding an
ACCESS_ONCE() to make sure tun->numqueues were only read once.

Bug were introduced by commit ca420e6eb688e160642f883a32ba860eda46cd6f
(tuntap: multiqueue support).

Reported-by: Michael S. Tsirkin <mst@redhat.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/tun.c