]> git.baikalelectronics.ru Git - kernel.git/commit
net: macb: Restart tx only if queue pointer is lagging
authorTomas Melin <tomas.melin@vaisala.com>
Thu, 7 Apr 2022 16:16:59 +0000 (19:16 +0300)
committerJakub Kicinski <kuba@kernel.org>
Tue, 12 Apr 2022 01:18:07 +0000 (18:18 -0700)
commit50e61c12c5f75e449a543eeef7259678c8220ad6
tree8c19022afe45c720b6f2e849061571d307222a63
parent7df7d878a1e19c0bf5b9bea2c6cbed72be19d5ff
net: macb: Restart tx only if queue pointer is lagging

commit 90f2168fffb6 ("net: macb: restart tx after tx used bit read")
added support for restarting transmission. Restarting tx does not work
in case controller asserts TXUBR interrupt and TQBP is already at the end
of the tx queue. In that situation, restarting tx will immediately cause
assertion of another TXUBR interrupt. The driver will end up in an infinite
interrupt loop which it cannot break out of.

For cases where TQBP is at the end of the tx queue, instead
only clear TX_USED interrupt. As more data gets pushed to the queue,
transmission will resume.

This issue was observed on a Xilinx Zynq-7000 based board.
During stress test of the network interface,
driver would get stuck on interrupt loop within seconds or minutes
causing CPU to stall.

Signed-off-by: Tomas Melin <tomas.melin@vaisala.com>
Tested-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Link: https://lore.kernel.org/r/20220407161659.14532-1-tomas.melin@vaisala.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/cadence/macb_main.c