]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "tcp: change pingpong threshold to 3"
authorWei Wang <weiwan@google.com>
Thu, 21 Jul 2022 20:44:04 +0000 (20:44 +0000)
committerJakub Kicinski <kuba@kernel.org>
Fri, 22 Jul 2022 22:09:10 +0000 (15:09 -0700)
commit50b6b74acb305c445e0798100fd3a75ca6367b7b
tree1abb5cdb4189b78d65eda21b514448946d3bc54c
parentc714d88e07b965fe274c8ba10faa4c8b11cbec85
Revert "tcp: change pingpong threshold to 3"

This reverts commit f8c8f53658928f7ed32acb954b15ca82a906e085.

This to-be-reverted commit was meant to apply a stricter rule for the
stack to enter pingpong mode. However, the condition used to check for
interactive session "before(tp->lsndtime, icsk->icsk_ack.lrcvtime)" is
jiffy based and might be too coarse, which delays the stack entering
pingpong mode.
We revert this patch so that we no longer use the above condition to
determine interactive session, and also reduce pingpong threshold to 1.

Fixes: f8c8f5365892 ("tcp: change pingpong threshold to 3")
Reported-by: LemmyHuang <hlm3280@163.com>
Suggested-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Wei Wang <weiwan@google.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20220721204404.388396-1-weiwan@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/inet_connection_sock.h
net/ipv4/tcp_output.c