]> git.baikalelectronics.ru Git - kernel.git/commit
regulator: tps65217-regulator: Remove pointless 'is unsigned int <0' check
authorLee Jones <lee.jones@linaro.org>
Fri, 26 Jun 2020 06:57:34 +0000 (07:57 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 26 Jun 2020 14:34:21 +0000 (15:34 +0100)
commit502b8a4c0bd2b3433063e76b989930098146dfe3
treebf07d97169cd047e57316c704b6cf5b03c75752d
parent4804bc511185408bea3bddc830f585afd30b39ac
regulator: tps65217-regulator: Remove pointless 'is unsigned int <0' check

'rid' is declared as unsigned int, so there is little point checking for <0.

Removing these checks fixes the following W=1 warnings:

 drivers/regulator/tps65217-regulator.c: In function ‘tps65217_pmic_set_suspend_enable’:
 drivers/regulator/tps65217-regulator.c:127:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
 127 | if (rid < TPS65217_DCDC_1 || rid > TPS65217_LDO_4)
 | ^
 drivers/regulator/tps65217-regulator.c: In function ‘tps65217_pmic_set_suspend_disable’:
 drivers/regulator/tps65217-regulator.c:140:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
 140 | if (rid < TPS65217_DCDC_1 || rid > TPS65217_LDO_4)
 | ^

Signed-off-by: Lee Jones <lee.jones@linaro.org>
Cc: Russ Dill <Russ.Dill@ti.com>
Cc: Keerthy <j-keerthy@ti.com>
Cc: AnilKumar Ch <anilkumar@ti.com>
Cc: linux-omap@vger.kernel.org
Link: https://lore.kernel.org/r/20200626065738.93412-6-lee.jones@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/tps65217-regulator.c