]> git.baikalelectronics.ru Git - kernel.git/commit
pinctrl-sunxi: sunxi_pinctrl_gpio_direction_in/output: use correct offset
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 26 Jan 2022 11:02:04 +0000 (12:02 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 28 Feb 2022 22:52:20 +0000 (23:52 +0100)
commit4f499dafffdf394fd1d48a705b22e6b0ada5792b
tree05a02e3e095d4b3eed9ea5570f6d88cb6d53acf4
parent4383e231a606264090663083910f20a31927ae1d
pinctrl-sunxi: sunxi_pinctrl_gpio_direction_in/output: use correct offset

The commit that sets the direction directly without calling
pinctrl_gpio_direction(), forgot to add chip->base to the offset when
calling sunxi_pmx_gpio_set_direction().

This caused failures for various Allwinner boards which have two
GPIO blocks.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reported-by: 5kft <5kft@5kft.org>
Suggested-by: 5kft <5kft@5kft.org>
Reported-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Fixes: d15eddb526d9 (pinctrl-sunxi: don't call pinctrl_gpio_direction())
Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Tested-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Link: https://lore.kernel.org/r/0f536cd8-01db-5d16-2cec-ec6d19409a49@xs4all.nl
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
[Picked from linux-next to pinctrl fixes]
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/sunxi/pinctrl-sunxi.c