]> git.baikalelectronics.ru Git - kernel.git/commit
asix: Ensure asix_rx_fixup_info members are all reset
authorDean Jenkins <Dean_Jenkins@mentor.com>
Mon, 7 Aug 2017 08:50:15 +0000 (09:50 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 7 Aug 2017 17:10:19 +0000 (10:10 -0700)
commit4f292a2feee4acf12fc997e014cf92bb18c399bc
treed974bf71d91054f1995708bec4b9830dbde91e57
parent2f01855f8e4f6cf16b7bd3171a5dd0141ac5fd73
asix: Ensure asix_rx_fixup_info members are all reset

There is a risk that the members of the structure asix_rx_fixup_info
become unsynchronised leading to the possibility of a malfunction.

For example, rx->split_head was not being set to false after an
error was detected so potentially could cause a malformed 32-bit
Data header word to be formed.

Therefore add function reset_asix_rx_fixup_info() to reset all the
members of asix_rx_fixup_info so that future processing will start
with known initial conditions.

Also, if (skb->len != offset) becomes true then call
reset_asix_rx_fixup_info() so that the processing of the next URB
starts with known initial conditions. Without the call, the check
does nothing which potentially could lead to a malfunction
when the next URB is processed.

In addition, for robustness, call reset_asix_rx_fixup_info() before
every error path's "return 0". This ensures that the next URB is
processed from known initial conditions.

Signed-off-by: Dean Jenkins <Dean_Jenkins@mentor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/asix_common.c