]> git.baikalelectronics.ru Git - kernel.git/commit
tracing: Use address-of operator on section symbols
authorNathan Chancellor <natechancellor@gmail.com>
Thu, 20 Feb 2020 05:10:12 +0000 (22:10 -0700)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Thu, 19 Mar 2020 20:27:41 +0000 (16:27 -0400)
commit4f1b2d8e253d3f36e22d1bd1001cff4cf93e2bae
treef604464450bf9533e0685cb7965cb5e23070ce21
parent7b2df44b91a8709befa4547231fbcd3f820ed370
tracing: Use address-of operator on section symbols

Clang warns:

../kernel/trace/trace.c:9335:33: warning: array comparison always
evaluates to true [-Wtautological-compare]
        if (__stop___trace_bprintk_fmt != __start___trace_bprintk_fmt)
                                       ^
1 warning generated.

These are not true arrays, they are linker defined symbols, which are
just addresses. Using the address of operator silences the warning and
does not change the runtime result of the check (tested with some print
statements compiled in with clang + ld.lld and gcc + ld.bfd in QEMU).

Link: http://lkml.kernel.org/r/20200220051011.26113-1-natechancellor@gmail.com
Link: https://github.com/ClangBuiltLinux/linux/issues/893
Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace.c