]> git.baikalelectronics.ru Git - kernel.git/commit
Bluetooth: vhci: Ignore return code of nonseekable_open()
authorDavid Herrmann <dh.herrmann@googlemail.com>
Wed, 28 Mar 2012 09:48:42 +0000 (11:48 +0200)
committerGustavo Padovan <gustavo@padovan.org>
Wed, 9 May 2012 03:41:36 +0000 (00:41 -0300)
commit4f09e7bf03285a885d30579759fdc8306682eedd
treefdee2cb96672cbd583738a13086210dc528d1d1d
parent01aee38bebad674485409b5dd87bce0cd4190001
Bluetooth: vhci: Ignore return code of nonseekable_open()

The comment in ./fs/open.c clearly states that nonseekable_open() will
never fail. Therefore, we can safely ignore the return code. This is the
recommended way to deal with nonseekable_open().
Our current code looks like nonseekable_open() is checked for the return
code. However, if we check the return code, we must also kfree() our
private data if the open fails. To avoid this overhead and to avoid
confusion, we simply drop the return code and return 0.

Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
drivers/bluetooth/hci_vhci.c