]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: properly wait for SBI status
authorEugeni Dodonov <eugeni.dodonov@intel.com>
Fri, 8 Jun 2012 19:43:19 +0000 (16:43 -0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 18 Jun 2012 07:57:07 +0000 (09:57 +0200)
commit4f07e2063232e795ac5f19d0d356fb22708e1c5a
treee6dbd47956146d41db3e364108a21021de431da7
parent45b6ca265a8aa9aecd8caf0f520139efe6db91f7
drm/i915: properly wait for SBI status

Somehow this went unnoticed in the past reviews, but the condition would
never timeout properly.

This was initially introduced in the v2 of original SBI enabling patch.
Highly embarrassing.

Note that we now actually time out for the read, which resulted in gcc
complaining that we can now return unitialized garbage if that
happens. There's not much we can do here because there's not much
point in thread -EIO all the way down through these functions. Hence
simply shut up the compiler.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
[danvet: Added note and squashed uninitialized value shut-up into this
patch.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_display.c