]> git.baikalelectronics.ru Git - kernel.git/commit
net: lapbether: fix issue of dev reference count leakage in lapbeth_device_event()
authorZhengchao Shao <shaozhengchao@huawei.com>
Thu, 3 Nov 2022 09:05:37 +0000 (17:05 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 7 Nov 2022 09:31:26 +0000 (09:31 +0000)
commit4f06d2cf7290ab4a05581f40cb5c6ed3b2fb9d91
treecb77c29aaafad44d556a7edbeb19bfe08d8881b8
parentb46bec6ae9817c2ed3c425213b1ee729c42576b6
net: lapbether: fix issue of dev reference count leakage in lapbeth_device_event()

When following tests are performed, it will cause dev reference counting
leakage.
a)ip link add bond2 type bond mode balance-rr
b)ip link set bond2 up
c)ifenslave -f bond2 rose1
d)ip link del bond2

When new bond device is created, the default type of the bond device is
ether. And the bond device is up, lapbeth_device_event() receives the
message and creates a new lapbeth device. In this case, the reference
count value of dev is hold once. But after "ifenslave -f bond2 rose1"
command is executed, the type of the bond device is changed to rose. When
the bond device is unregistered, lapbeth_device_event() will not put the
dev reference count.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/lapbether.c