]> git.baikalelectronics.ru Git - kernel.git/commit
dm crypt: fix benbi IV constructor crash if used in authenticated mode
authorMilan Broz <gmazyland@gmail.com>
Mon, 6 Jan 2020 09:11:47 +0000 (10:11 +0100)
committerMike Snitzer <snitzer@redhat.com>
Wed, 15 Jan 2020 01:22:47 +0000 (20:22 -0500)
commit4ea9471fbd1addb25a4d269991dc724e200ca5b5
treefd553b836f98ce14f66ca7a0b70a75f96f93d067
parentbbb1658461ac85ef7e0563bb11283f94ea5eb651
dm crypt: fix benbi IV constructor crash if used in authenticated mode

If benbi IV is used in AEAD construction, for example:
  cryptsetup luksFormat <device> --cipher twofish-xts-benbi --key-size 512 --integrity=hmac-sha256
the constructor uses wrong skcipher function and crashes:

 BUG: kernel NULL pointer dereference, address: 00000014
 ...
 EIP: crypt_iv_benbi_ctr+0x15/0x70 [dm_crypt]
 Call Trace:
  ? crypt_subkey_size+0x20/0x20 [dm_crypt]
  crypt_ctr+0x567/0xfc0 [dm_crypt]
  dm_table_add_target+0x15f/0x340 [dm_mod]

Fix this by properly using crypt_aead_blocksize() in this case.

Fixes: ef43aa38063a6 ("dm crypt: add cryptographic data integrity protection (authenticated encryption)")
Cc: stable@vger.kernel.org # v4.12+
Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=941051
Reported-by: Jerad Simpson <jbsimpson@gmail.com>
Signed-off-by: Milan Broz <gmazyland@gmail.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-crypt.c