]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "floppy: reintroduce O_NDELAY fix"
authorDenis Efremov <efremov@linux.com>
Sat, 7 Aug 2021 07:37:02 +0000 (10:37 +0300)
committerDenis Efremov <efremov@linux.com>
Sat, 28 Aug 2021 08:16:47 +0000 (11:16 +0300)
commit4e686b16ae3b726878baeed6545e60dd74aeb6ca
tree3f65512ea1fbff6549f74b824fd3ce2f044d843b
parent094eb122355e90398946a9eadbd5451d32abd07c
Revert "floppy: reintroduce O_NDELAY fix"

The patch breaks userspace implementations (e.g. fdutils) and introduces
regressions in behaviour. Previously, it was possible to O_NDELAY open a
floppy device with no media inserted or with write protected media without
an error. Some userspace tools use this particular behavior for probing.

It's not the first time when we revert this patch. Previous revert is in
commit f3cb546aa3fc (Revert "floppy: refactor open() flags handling").

This reverts commit b5d466a6975d730860bca362bec15cdfb4be2b41.

Link: https://lore.kernel.org/linux-block/de10cb47-34d1-5a88-7751-225ca380f735@compro.net/
Reported-by: Mark Hounschell <markh@compro.net>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Wim Osterholt <wim@djo.tudelft.nl>
Cc: Kurt Garloff <kurt@garloff.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Denis Efremov <efremov@linux.com>
drivers/block/floppy.c