]> git.baikalelectronics.ru Git - kernel.git/commit
nfsd: do_probe_callback should not clear rpc stats
authorBenny Halevy <bhalevy@panasas.com>
Fri, 26 Sep 2008 12:14:13 +0000 (15:14 +0300)
committerJ. Bruce Fields <bfields@citi.umich.edu>
Mon, 29 Sep 2008 22:13:40 +0000 (18:13 -0400)
commit4e577ba59bdfd41f72c39856b95b433dbee9060c
treebdb97a295476b8f934c6295b4a2faa9511311b30
parentc65f20e7bfd47e1abc78a00345f85be50e595491
nfsd: do_probe_callback should not clear rpc stats

Now that cb_stats are static (since commit
be964a673aafb4be07c8e85d45672baeaed97f34)
there's no need to clear them.

Initially I thought it might make sense to do
that every callback probing but since the stats
are per-program and they are shared between possibly
several client callback instances, zeroing them out
seems like the wrong thing to do.

Note that that commit also introduced a bug
since stats.program is also being cleared in the process
and it is not restored after the memset as it used to be.

Signed-off-by: Benny Halevy <bhalevy@panasas.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
fs/nfsd/nfs4callback.c