]> git.baikalelectronics.ru Git - kernel.git/commit
i2c-s3c2410: Correct use of ! and &
authorJulia Lawall <julia@diku.dk>
Thu, 30 Oct 2008 14:55:47 +0000 (15:55 +0100)
committerJean Delvare <khali@linux-fr.org>
Thu, 30 Oct 2008 14:55:47 +0000 (15:55 +0100)
commit4e205cce4e28a31ec79084c816a03439b6d52e91
tree3a04ba9e00486ecc8490f86ef0ff9d2468d2eb2b
parentd2256478fce9783bb71409dab2eb5806510080df
i2c-s3c2410: Correct use of ! and &

In commit fbb1ccd43b0dfa2ef851295f09c104022e4e2c88, a bug was fixed that
involved converting !x & y to !(x & y).  The code below shows the same
pattern, and thus should perhaps be fixed in the same way.  In particular,
the result of !readl(i2c->regs + S3C2410_IICCON) & S3C2410_IICCON_IRQEN is
always 0.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@ expression E; constant C; @@
(
  !E & !C
|
- !E & C
+ !(E & C)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
drivers/i2c/busses/i2c-s3c2410.c