]> git.baikalelectronics.ru Git - kernel.git/commit
macvlan: Fix potential use-after free for broadcasts
authorHerbert Xu <herbert@gondor.apana.org.au>
Wed, 1 Jun 2016 03:43:00 +0000 (11:43 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 2 Jun 2016 00:48:46 +0000 (17:48 -0700)
commit4e17baffa6e3fbe1f85dc756da7ccdf2e26bb799
treef3d2d75d159a68ee886d04cd130d05107f388bbd
parent3065f265c64f14464635d10452918abed77088ac
macvlan: Fix potential use-after free for broadcasts

When we postpone a broadcast packet we save the source port in
the skb if it is local.  However, the source port can disappear
before we get a chance to process the packet.

This patch fixes this by holding a ref count on the netdev.

It also delays the skb->cb modification until after we allocate
the new skb as you should not modify shared skbs.

Fixes: 3befbe94a40a ("macvlan: Move broadcasts into a work queue")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/macvlan.c