]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: lpfc: Prevent lpfc_debugfs_lockstat_write() buffer overflow
authorJustin Tee <justin.tee@broadcom.com>
Wed, 1 Mar 2023 23:16:17 +0000 (15:16 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 May 2023 16:32:37 +0000 (17:32 +0100)
commit4e0e613307aa84974e630f60e5d045f4b234093b
tree63f0ebdd714360796b0aba27c38f57b52c8ed051
parent2ca0486d41e0c64ba7e79d6f2d91e6e4bb5f47ce
scsi: lpfc: Prevent lpfc_debugfs_lockstat_write() buffer overflow

[ Upstream commit c6087b82a9146826564a55c5ca0164cac40348f5 ]

A static code analysis tool flagged the possibility of buffer overflow when
using copy_from_user() for a debugfs entry.

Currently, it is possible that copy_from_user() copies more bytes than what
would fit in the mybuf char array.  Add a min() restriction check between
sizeof(mybuf) - 1 and nbytes passed from the userspace buffer to protect
against buffer overflow.

Link: https://lore.kernel.org/r/20230301231626.9621-2-justintee8345@gmail.com
Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/lpfc/lpfc_debugfs.c