]> git.baikalelectronics.ru Git - kernel.git/commit
powerpc/64s: Disable stack variable initialisation for prom_init
authorMichael Ellerman <mpe@ellerman.id.au>
Mon, 18 Jul 2022 13:44:18 +0000 (23:44 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 20 Jul 2022 05:13:02 +0000 (15:13 +1000)
commit4d547331b51f8289a9b53debac771296f3dd097a
tree555542ae4769b6fb0dee72111cc950e4cdf15c31
parentda5b427bc3f46400e4c723e10e83cda293dd983f
powerpc/64s: Disable stack variable initialisation for prom_init

With GCC 12 allmodconfig prom_init fails to build:

  Error: External symbol 'memset' referenced from prom_init.c
  make[2]: *** [arch/powerpc/kernel/Makefile:204: arch/powerpc/kernel/prom_init_check] Error 1

The allmodconfig build enables KASAN, so all calls to memset in
prom_init should be converted to __memset by the #ifdefs in
asm/string.h, because prom_init must use the non-KASAN instrumented
versions.

The build failure happens because there's a call to memset that hasn't
been caught by the pre-processor and converted to __memset. Typically
that's because it's a memset generated by the compiler itself, and that
is the case here.

With GCC 12, allmodconfig enables CONFIG_INIT_STACK_ALL_PATTERN, which
causes the compiler to emit memset calls to initialise on-stack
variables with a pattern.

Because prom_init is non-user-facing boot-time only code, as a
workaround just disable stack variable initialisation to unbreak the
build.

Reported-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220718134418.354114-1-mpe@ellerman.id.au
arch/powerpc/kernel/Makefile