]> git.baikalelectronics.ru Git - kernel.git/commit
ext4: don't return to userspace after freezing the fs with a mutex held
authorEric Sandeen <sandeen@redhat.com>
Sun, 16 May 2010 06:00:00 +0000 (02:00 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sun, 16 May 2010 06:00:00 +0000 (02:00 -0400)
commit4c922dc8282de705eb36b3b1487542ad4dcd9158
tree6c15fad6ca442d92e8075578a9b04811ca093bda
parentc11eed723e23c859e1e9a33033f74b18b01e848a
ext4: don't return to userspace after freezing the fs with a mutex held

ext4_freeze() used jbd2_journal_lock_updates() which takes
the j_barrier mutex, and then returns to userspace.  The
kernel does not like this:

================================================
[ BUG: lock held when returning to user space! ]
------------------------------------------------
lvcreate/1075 is leaving the kernel with locks still held!
1 lock held by lvcreate/1075:
 #0:  (&journal->j_barrier){+.+...}, at: [<ffffffff811c6214>]
jbd2_journal_lock_updates+0xe1/0xf0

Use vfs_check_frozen() added to ext4_journal_start_sb() and
ext4_force_commit() instead.

Addresses-Red-Hat-Bugzilla: #568503

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/super.c